Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #263

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Cleanups #263

merged 6 commits into from
Feb 6, 2024

Conversation

andlaus
Copy link
Collaborator

@andlaus andlaus commented Feb 6, 2024

This PR contains a bunch of stuff which I've recently stumbled over while refactoring the decoding logic (PRs coming soon), but is unrelated to that functionality.

Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information

the `.bit_length` attribute does *not* specify the size of the while
object, but only the size of the length indicator at the beginning of
the object. This is then followed by an array of the size of the value
given in this length indicator field.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
this simplifies the debugging experience a bit. For now, list
comprehensions stay as they are because they are usually very
simple...

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
if these parameters where specified explicitly, their value was
encoded into the blob twice: once whilst going over all parameters and
once for the post processing step which is required due to the
possibility to specify these parameters implicitly. This avoids the
warning.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
Once upon a time, the `response_type` property of `Response` objects
used to be a string. In modern times it has become an enum in order to
make it play nicely with type checking.

Besides this, the output of the snoop tool is slightly decluttered,
i.e., it does not prefix everything which is send by the tester by
`tester:` and everything send by the ECU by `ECU:`. (this is IMO quite
clear from the context.)

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
…de()`

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
@andlaus andlaus merged commit 76a4c44 into mercedes-benz:main Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants